I like my shorts a little shorter, so most of my short stop 2-3 inches above my knees. For most guys, 7″ shorts are the perfect above-the-knee length. They should stop at the top of your kneecaps (at the longest). Just like with swim trunks, it’s crucial that your shorts don’t go past your knees.
Let’s start with the length… Shorts Length: How Long Should Men’s Shorts Be?
To make sure your shorts flatter your body type, you need to pay attention to the length AND the width (the leg opening).